inbo / craywatch

Craywatch project website
https://craywatch.inbo.be
Creative Commons Attribution 4.0 International
1 stars 0 forks source link

Show reserved locations on the map #210

Closed damianooldoni closed 4 months ago

damianooldoni commented 4 months ago

Reserved locations are locations in locaties.csv where isReserved = TRUE.

These locations are points and will have to be shown as leaflet markers. By clicking on it a pop up should appear containing: locatieID, gemeente.

This layer must be shown by default.

damianooldoni commented 4 months ago

@fjasteen: the leaflet with the default layer is online. As written in the Pull Request #236, this is a dummy. But it is exactly the same as the file locaties.csv I will generate and maintain based on the geopackage you will provide. I will leave this issue open until the real map is shown. Feedback is also welcome!

damianooldoni commented 4 months ago

Tasks to tackle:

~fetch the csv from GDrive. Notice that it's a csv, not a tabular gsheet published online and so directly downloadable. Still, this seems quite easy as the csv is publicly available.~

damianooldoni commented 4 months ago

PR #255 solved second and third step. Still to do:

damianooldoni commented 4 months ago

I think that fetching data from GDrive is not optimal. By maintaining the csv file in this repo will allow us to trace changes if something gets wrong. You know, git can save us a lot of work.

To be discussed in a few hours with @fjasteen, @margotvermeylen and @biekemaex

fjasteen commented 4 months ago

Few changes to the localities.csv

biekemaex commented 4 months ago

Suggestion for a colour palette with 8 distinct colours: https://coolors.co/264653-287271-2a9d8f-8ab17d-e9c46a-f4a261-e76f51-eb886f

We think the Dark Matter and Grey Canvas maps are probably not necessary, the rest can stay!

damianooldoni commented 4 months ago

@fjasteen and I agreed on Thursday afternoon to maintain the locations as csv in this repo in folder /assets. Copy on GDrive can, but, very important, the website will read the csv file in this repo.

damianooldoni commented 4 months ago

Thanks @biekemaex and @fjasteen for your inputs about the csv file and all other visualization options. I will try to implement all of them today, but no guarantee. Tomorrow at latest.

damianooldoni commented 4 months ago

Issue completed by #273.