inbo / etn

R package to access data from the European Tracking Network
https://inbo.github.io/etn/
MIT License
6 stars 5 forks source link

Fields without a name in field_definitions #127

Closed peterdesmet closed 4 years ago

peterdesmet commented 4 years ago

Reported by @fwaumans:

Er zijn vier velden waar ik een probleem mee heb en waarvan de database_column_name leeg is.

@fwaumans

peterdesmet commented 4 years ago

activation_date in tags_view2 seems to be dropped too

fwaumans commented 4 years ago

Indeed, the database_column_name is populated and the field is empty.

I am using field on https://inbo.github.io/etn/articles/etn_fields.html, because I assumed that is the field name as it appears in the animal_view2, receivers_view2, etc. view?

Correct

fwaumans commented 4 years ago

For the animal view. I don't understand the difference between pk and animal_id

view/table field (animals) suggested_field in database
id_pk pk primary key (autoincrement field)
id_pk animal_id primary key (autoincrement field)
animal_id animal_label unique label given by researcher
fwaumans commented 4 years ago

Receivers What is the difference between telemetry_type and application_type?

fwaumans commented 4 years ago

Tags: I will rename the field thelma_converted_code by tag_id_alternative

peterdesmet commented 4 years ago

Tags: I will rename the field thelma_converted_code by tag_id_alternative

:+1: tag_id_alternative should be the 3rd field, between tag_id and telemetry_type

Receivers: What is the difference between telemetry_type and application_type?

application_type is a high level distinction (populated with cpod or acoustic_telemetry), but telemetry_type seems never populated. I'm not sure what is should be populated with (@jreubens @PieterjanVerhelst), but for now it can be added to the list of fields without definition.

animal view. I don't understand the difference between pk and animal_id

The field that was in the old views called animal_id should be called animal_label ("Identification code that uniquely identifies each animal, as specified by the researcher.") and 2 fields should be based on id_pk: the pk and animal_id. There is no difference between these, but for consistency with tags and receivers we opted to have a pk and an _id field. For animals these just contain the same content.

fwaumans commented 4 years ago

Ok for tags and animals.

About the difference between telemetry_type and application_type (receivers). I think for application_type the two different values should be telemetry (=tracking of tagged (known) animals' ) or cpod (=tracking of non-tagged (not-known) animals (porpoises)).

I case of telemetry you can specify the type of telemetry (telemetry_type): Acoustic, Archival, Satellite, PIT, Radio. At this moment we can only store acoustic telemetry data in the ETN database so I can complete telemetry_type with the value 'Acoustic'

jreubens commented 4 years ago

@fwaumans, @peterdesmet telemetry_type is indeed specifiying which telemetry technology you are using (i.e. acoustic, archival, satellite, ...) But I don't see this column on receiver level, only on tag level...Where are you looking?

fwaumans commented 4 years ago

Tags: tag_id_alternative was added Receivers: the value 'acoustic' was completed in the field telemetry_type Animals; animal_idand id.pk were adjusted

peterdesmet commented 4 years ago

Thanks! I noticed step1_duration jumped in front of step1_power in tags, can you revert that to power, then duration?

fwaumans commented 4 years ago

Done!

peterdesmet commented 4 years ago

Thanks, fix now on website.