search

inbo / etn

R package to access data from the European Tracking Network
https://inbo.github.io/etn/
MIT License
6 stars 5 forks source link

Update funder, remove logo + custom authors #311

Closed peterdesmet closed 1 month ago

PietrH commented 1 month ago

If I run pkgdown::build_site() to have a look at the results, I modify a bunch of files. Is it safe/a good idea to commit these changes?

PietrH commented 1 month ago

The navbar looks very dark when I build on the VLIZ RStudio server:

image

@peterdesmet How does this look on your end?

peterdesmet commented 1 month ago

Is it safe/a good idea to commit these changes?

Yes, we currently have to build and commit the website ourselves (not through GitHub Actions). And the current website has errors in all examples, so good to have it updated.

Longer term, this should be done through GitHub Actions on a gh-pages branch.

Could you have a look at the navbar?

Can you install the latest version of pkgdown?

PietrH commented 1 month ago

Can you install the latest version of pkgdown?

Not via install.packages because the latest version doesn't support R 3.6.0, I could install it via remotes but I'd have to look into why they dropped support first

PietrH commented 1 month ago

I was able to get it to work with pkgdown v2.0.9 installed via remotes;

image

This release is two versions behind the current HEAD, more recent developments on pkgdown use a function in tools that depends on R>4.0.0