search

inbo / fistools

Repo containing widely used data & functions of the FIS team
https://inbo.github.io/fistools/
Other
1 stars 0 forks source link

16 new function download file from googledrive #18

Closed SanderDevisscher closed 5 months ago

SanderDevisscher commented 5 months ago

Fixes #16

to test function:

devtools::install_github("inbo/fistools@16-new-function-download-file-from-googledrive")
download_gdrive_if_missing(gfileID = "1gtqcZojPnbLhEgpul3r9sy2zK3UyyCVG",
                            destfile = "../../Teamcharters/Teamcharter_FIS.pdf",
                            email = Sys.getenv("email"),
                            update_always = TRUE)

after pr 

devtools::install_github("inbo/fistools")
download_gdrive_if_missing(gfileID = "1gtqcZojPnbLhEgpul3r9sy2zK3UyyCVG",
                            destfile = "../../Teamcharters/Teamcharter_FIS.pdf",
                            email = Sys.getenv("email"),
                            update_always = TRUE)
SanderDevisscher commented 5 months ago

@LynnPallemaerts kan jij deze functie even testen in je concrete case ?

LynnPallemaerts commented 5 months ago

@SanderDevisscher Ik heb een extra example geprobeerd (gecommit en gepushed) en dat lijkt te werken!

SanderDevisscher commented 5 months ago

ifso mag je approven en zal ik mergen nadat de checks voldaan zijn.

LynnPallemaerts commented 5 months ago

@SanderDevisscher But did I do the example thing right?

SanderDevisscher commented 5 months ago

@SanderDevisscher But did I do the example thing right?

Yes, the checks haven't failed! If you want to be 100% sure you can run devtools::check() in the console. If there are no warnings nor errors and fewer than 2 notes, everything is as it should be.