Closed PietrH closed 9 months ago
Attention: 16 lines
in your changes are missing coverage. Please review.
Comparison is base (
56a0bb0
) 0.00% compared to head (08622e8
) 0.00%.:exclamation: Current head 08622e8 differs from pull request most recent head 1479cb2. Consider uploading reports for the commit 1479cb2 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
An issue remains where only one image url seems to be fetched for all records
An issue remains where only one image url seems to be fetched for all records
False alarm, I was looking at foto_bestrijding
which only has a value for a single record.
@SanderDevisscher Is there any must have functionality missing from get_records()
, or can we go ahead and merge into main and work on the other features independently?
Feel free to try it out on this branch with: get_records(access_token = get_access_token(username = "your_username"))
You'll need to install the package first, you can do this by hitting the Install button, under Build in RStudio. This should be visible if you load the project included in this repo. Let me know if you need any help! :wink:
@SanderDevisscher Is there any must have functionality missing from get_records()
, or can we go ahead and merge into main and work on the other features independently?
Feel free to try it out on this branch with: get_records(access_token = get_access_token(username = "your_username"))
You'll need to install the package first, you can do this by hitting the Install button, under Build in RStudio. This should be visible if you load the project included in this repo. Let me know if you need any help! :wink:
Still in draft, should I wait ?
Sorry, no go ahead
get_records()
is now in a minimally functional state.What works:
Vespa-Watch
What is missing:
2. Valideren
get_fields()
toestemming_gegevensgebruik == "on"
might make more sense astoestemming_gegevensgebruik == TRUE
, we could use date and time fields fordatum_tijd_registratie
anddatum_observatie
to save users on having to to these conversions themselves.Questions
https://drive.google.com/file/d/1a8bVYH_SYoZklF8xKLRBixdFGvlfgGh-