inbo / iassetR

Interact with the iAsset api using R
https://inbo.github.io/iassetR/
Other
0 stars 1 forks source link

Add basic functionality of `get_records()` #12

Closed PietrH closed 9 months ago

PietrH commented 9 months ago

get_records() is now in a minimally functional state.

What works:

What is missing:

Questions

https://drive.google.com/file/d/1a8bVYH_SYoZklF8xKLRBixdFGvlfgGh-

codecov[bot] commented 9 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (56a0bb0) 0.00% compared to head (08622e8) 0.00%.

:exclamation: Current head 08622e8 differs from pull request most recent head 1479cb2. Consider uploading reports for the commit 1479cb2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12 +/- ## ===================================== Coverage 0.00% 0.00% ===================================== Files 3 3 Lines 47 61 +14 ===================================== - Misses 47 61 +14 ``` | [Files](https://app.codecov.io/gh/inbo/vespawatchr/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inbo) | Coverage Δ | | |---|---|---| | [R/get\_records.R](https://app.codecov.io/gh/inbo/vespawatchr/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inbo#diff-Ui9nZXRfcmVjb3Jkcy5S) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PietrH commented 9 months ago

An issue remains where only one image url seems to be fetched for all records

PietrH commented 9 months ago

An issue remains where only one image url seems to be fetched for all records

False alarm, I was looking at foto_bestrijding which only has a value for a single record.

PietrH commented 9 months ago

@SanderDevisscher Is there any must have functionality missing from get_records(), or can we go ahead and merge into main and work on the other features independently?

Feel free to try it out on this branch with: get_records(access_token = get_access_token(username = "your_username"))

You'll need to install the package first, you can do this by hitting the Install button, under Build in RStudio. This should be visible if you load the project included in this repo. Let me know if you need any help! :wink:

PietrH commented 9 months ago

@SanderDevisscher Is there any must have functionality missing from get_records(), or can we go ahead and merge into main and work on the other features independently?

Feel free to try it out on this branch with: get_records(access_token = get_access_token(username = "your_username"))

You'll need to install the package first, you can do this by hitting the Install button, under Build in RStudio. This should be visible if you load the project included in this repo. Let me know if you need any help! :wink:

SanderDevisscher commented 9 months ago

Still in draft, should I wait ?

PietrH commented 9 months ago

Sorry, no go ahead