PietrH
commented
9 months ago Sander, here is what I think you need to test:
- Does this break you local version of the package (yes!): can you get it to work again by cloning
- Does this branch pass R CMD CHECK for you, this is under the build tab of RStudio
- Can you get any function to break that wasn't already broken after this change
- Does this break the other (hopefully very experimental) scripts that you have that are dependent on
iassetR - Did I miss anything while renaming the package?
Also:
How are we going to handle references to vespawatch going forward, ie in the function documentation and examples. In default values etc. I say we keep them in for now, but it might be a pain removing them later. It's a balance of user friendliness towards ourselves as users, and possible other users that don't know about vespawatch in the future.
We might want to avoid setting default values to vespawatch defaults, but it would be handy for us... We could also handle this with System ENV parameters, but I always find that less user friendly when I'm using a new package since this is stuff I can't really see in my IDE. What do you think?
SanderDevisscher
Me and @SanderDevisscher have decided to rename the repo, and package from
vespawatchrtoiassetRbecause while we currently are writing this in the scope of vespawatch, we want to keep the package general enough to be used by any iAsset user. Any vespawatch specific code should go in vespawatch specific repo's.@SanderDevisscher , I'm setting you as reviewer as soon as this is ready for review. But I would like to merge it into main myself.
From this merge onwards, anyone developing on this package will have to update their local versions to the new repo and project. You can do this in Git CLI or Github Desktop (under repository), but I usually find it easier to just delete my local copy and to clone a new one.