Closed PietrH closed 8 months ago
@PietrH can I test this ?
PS it works
Thanks for having a look at it Sander, I'm not ready with this branch yet. I've added a todo list to this PR.
Sorry it's been dragging on. Do you have any experience writing tests with testthat?
Sorry no experience with testthat, however I'm willing to learn.
No worries, we can get together about that at some point. There is some information about it in the R packages book: https://r-pkgs.org/testing-basics.html
I'll take care of the unit tests for this PR though, don't worry!
No worries, we can get together about that at some point. There is some information about it in the R packages book: https://r-pkgs.org/testing-basics.html
thanks
The failure state when you enter the wrong username isn't very elegant:
get_records(access_token = get_access_token(username = "pieter.huybrechts@inbo.be"))
#>Error: access_token is not a string (a length one character vector).
Select fields are recoded, currently radio
and select
fields are treated equally.
I've decided tests are for a seperate PR, in the context of #7 because it'll require a bit more tooling. I'd like to avoid mocking or vcr if at all possible.
The failure state when you enter the wrong username isn't very elegant:
get_records(access_token = get_access_token(username = "pieter.huybrechts@inbo.be")) #>Error: access_token is not a string (a length one character vector).
Issue for optionally returning verbatim field names as iAsset: #28
PS it works
I'm interpreting this as a positive review, and merging to main. If it's broken, please open an issue.
Todo
select_inspectors
is recoded- [ ] Add tests forget_records()
especially regarding recodingFALSE