search

inbo / iassetR

Interact with the iAsset api using R
https://inbo.github.io/iassetR/
Other
0 stars 1 forks source link

29 create citationcff #36

Closed PietrH closed 5 months ago

PietrH commented 6 months ago

Fixes #29

Also add a bugreports field to the description and a codemeta file

The codemeta project defines a metadata file: codemeta.json (in JSON-LD format) that helps machines interpret information about your package. This is useful because it can ease the attribution, discoverability and reuse of your code beyond the tools already present in the R ecosystem. A codemeta.json makes it more likely someone will find your software who doesn’t know where to look for it, and that you’ll get credit for it when it is reused by allowing different metadata standards to be translated into each other via codemeta. The codemeta project makes a strong case for it’s inclusion in repositories. And so does rOpenSci.

SanderDevisscher commented 6 months ago

@PietrH do you expect me to some in depth tests ? if so which ? or just approve & merge ?

PietrH commented 6 months ago

If it looks good you can approve, in general I prefer if the one who opens a PR/is assigned also does the merge.

In this case: see if you like the output of citation(), see if you agree with the changes I did to DESCRIPTION, what do you think about the codemeta project?

SanderDevisscher commented 6 months ago

I'll take a look

Op ma 12 feb. 2024 11:07 schreef Pieter Huybrechts @.***

:

If it looks good you can approve, in general I prefer if the one who opens a PR/is assigned also does the merge.

In this case: see if you like the output of citation(), see if you agree with the changes I did to DESCRIPTION, what do you think about the codemeta project?

— Reply to this email directly, view it on GitHub https://github.com/inbo/iassetR/pull/36#issuecomment-1938370435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEAAQOCA3SJR5TZAR32GRBTYTHSVBAVCNFSM6AAAAABDBHTWZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGM3TANBTGU . You are receiving this because your review was requested.Message ID: @.***>

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (b912fb1) to head (96a84b5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ===================================== Coverage 0.00% 0.00% ===================================== Files 4 4 Lines 131 131 ===================================== Misses 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.