Closed SanderDevisscher closed 4 months ago
As I understand it, we are currently using the system keyring.
I believe it goes: keyring -> service -> username/password combinations
From here: https://keyring.r-lib.org/index.html#github
Did you make changes to the workflow yml?
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes
MY_SECRET: ${{ secrets.my_secret }}
Interesting, what happens if you don't set a service name for name value pairs in keyring?
You could also create an issue in keyring to see if we are missing something.
This is costing me a lot of time can't we just revert to 8c012bfb40857cebacf90000623a51c2078b53ec ?
The decision is up to you, keyring seems like the best solution to me.
The documentation of keyring makes it sound like it's easy to use within github actions, so maybe we should ask them for help.
I'am experiencing issues with getting
get_records()
to run with github actions. I get the following error:in https://github.com/inbo/aspbo/actions/workflows/get_vespa_velutina_management.yaml. My latest run: https://github.com/inbo/aspbo/actions/runs/8615691797/job/23613099659
its seems the error occurs when the workflow runs the following code: https://github.com/inbo/aspbo/blob/afee4e3527ef617f9a1c6074242b838989d9ed71/src/Vespa%20velutina%20management/get_data_from_iAsset.Rmd#L33-L39
When I look at the keyring readme I see the following remark:
This makes me suspect adding
service = "iasset_password"
is the cause of this issue.PS I added "iasset_username" & "iasset_password" as github Actions secrets on the repository level.