search

inbo / iassetR

Interact with the iAsset api using R
https://inbo.github.io/iassetR/
Other
0 stars 1 forks source link

remove default username from get_access_token() #9

Closed SanderDevisscher closed 9 months ago

SanderDevisscher commented 9 months ago

fixes #5 by removing the hardcoded username in get_access_token

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@5e951a8). Click here to learn what that means.

:exclamation: Current head 92f20a4 differs from pull request most recent head e7f3915. Consider uploading reports for the commit e7f3915 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9 +/- ## ====================================== Coverage ? 0.00% ====================================== Files ? 3 Lines ? 47 Branches ? 0 ====================================== Hits ? 0 Misses ? 47 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PietrH commented 9 months ago

I've been a bit messy and there are some issues related to creating get_records() in this branch, I'll fix them here, merge to main and will be more sanitary in my branch use in the future.

PietrH commented 9 months ago

R CMD CHECK was failing because of some unfilled fields in the roxygen documentation of the functions, mostly examples (we could just not have an example, but might as well have something there). Also I had declared a dependency on dplyr that was unused, I'm sure we'll need it for get_records(), but I've removed it for now so the CI passes.