add DHMV API - Githubissues

inbo / inbospatial

🍁 Collection of useful R functions for spatial data

https://inbo.github.io/inbospatial

Other

5 stars 1 forks source link

add DHMV API #12

Open falkmielke opened 1 week ago

falkmielke commented 1 week ago

Adding functionality to query DHMV (Digital Elevation Model Flanders), with a vignette to explain query construction in detail.

falkmielke commented 1 week ago

(checks seem to fail due to an issue in the other vignette: https://github.com/inbo/inbospatial/issues/13 )

hansvancalster commented 4 days ago

I have changed the base branch to next-version

hansvancalster commented 3 days ago

(checks seem to fail due to an issue in the other vignette: #13 )

That should now be solved in the next-version branch. You can do git pull origin next-version with your branch checked out to align your branch with that branch.

falkmielke commented 2 days ago

I will update this branch with the other changes you implemented, and then test DHMV v2.0.1 and mht. Thanks a lot for your work, @hansvancalster !

falkmielke commented 2 days ago

Changes are incorporated, vignettes build fine, rebase was a mess (sorry!). TODOs:

tame the checklist package
double check the crs issue you mentioned above.

Again, thank you for the comments and suggestions @hansvancalster !