inbo / movepub

R package to prepare animal tracking data from Movebank for publication in a research repository or GBIF
https://inbo.github.io/movepub/
Other
3 stars 1 forks source link

Terms like `deploy-on measurements` written with hyphen in NERC #47

Closed peterdesmet closed 11 months ago

peterdesmet commented 1 year ago

@sarahcd I noticed that the following (new) terms have labels that are written with hyphen:

This in contrast with previous terms:

The extra hyphen makes it annoying to find the term, since we ignore all -, _, and . to look up a term. Is it possible to change the labels to make them consistent?

peterdesmet commented 1 year ago

Note also that some definitions in other terms (e.g. capture handling time) refer to the terms with hypnen, while they are written without:

The time elapsed between capture and release of the animal for the purpose of attaching the tag. Can also be calculated as the difference between 'deploy-on timestamp' and 'capture timestamp'. Example: '552'; Units: seconds; Entity described: deployment

peterdesmet commented 1 year ago

This issue is a blocker for publishing our data :-/

peterdesmet commented 1 year ago

Hi @sarahcd, any idea when this would be resolved in the vocabulary? Even adding the hyphen-less names as alternative label would resolve this, but better is to have them hyphen-less as canonical names.

sarahcd commented 1 year ago

Sorry for the trouble @peterdesmet — I noticed this also and have the changes prepared for the next update—removing hyphens from the names. I plan to do this in the next month.

peterdesmet commented 1 year ago

You expect an update in August? Great! I'll postpone publication until then, can you keep me posted?

sarahcd commented 1 year ago

Yes, and yes!

sarahcd commented 1 year ago

Fixed at http://vocab.nerc.ac.uk/collection/MVB with an update that went live last night. Sorry for the wait!

peterdesmet commented 11 months ago

Names confirmed fixed in latest update. @sarahcd note that some terms still refer to terms with hyphen in their description, maybe good to put on your radar for the next update. Closing issue.