search

inbo / movepub

R package to prepare animal tracking data from Movebank for publication in a research repository or GBIF
https://inbo.github.io/movepub/
Other
3 stars 1 forks source link

Fix bug in `get_mvb_term()`, create emof.csv, test `get_aphia_id()`, update vignette and reexport frictionless functions #81

Closed sannegovaert closed 1 month ago

sannegovaert commented 1 month ago

I combined some issues in this PR. If I would have split these, a bug (solved in this PR) would have hindered testing in other branches.

1) bug in get_mvb_term() is fixed (fix #82).

2) write_dwc() now creates and extended measurments or facts file, with measurement types life stage and sex. fix #77 fix #78

A measurementType is only included if at least 1 non-NA value for that measurementType exists (no tests yet). What if there is no information on sex nor lifeStage? Should no emof.csv be returned?

3) Add tests for get_aphia_id() and fix small issue (fix #53)

4) fix #79

5) fix #54

6) fix #58

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.36%. Comparing base (67a404c) to head (98b9518). Report is 47 commits behind head on main.

Files Patch % Lines
R/create_ref_emof.R 95.91% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================== + Coverage 87.30% 88.36% +1.06% ========================================== Files 9 10 +1 Lines 512 576 +64 ========================================== + Hits 447 509 +62 - Misses 65 67 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.