inbo / n2khab-mhq-data

Export data collected for the monitoring habitat quality programme from Fieldmap and INBOVeg database
0 stars 0 forks source link

Data cleaning, exploration and LSVI of HT31xx #25

Closed anleyssen closed 1 year ago

ToonHub commented 1 year ago

I managed to run the script without any errors and the code is documented quite well . Good!

But I still have some comments and suggestions. See below.

ToonHub commented 1 year ago

Some suggestions for the table site_caractheristics:

ToonHub commented 1 year ago

In the LSVI-calculation you use '1-out-all-out' for the aggregation. If you want to use the method that was used for the HR-reporting, you sould use Aggregatiemethode = "RapportageHR".

ToonHub commented 1 year ago

To make the code better readable I suggest to always start a new line after %>%

anleyssen commented 1 year ago

Suggested changes in HT31xx data preparation are made:

Some minor changes in HT31xx_LSVI (text edits) are also made. Can @ElsLommelen also review the code for LSVI-calculation?

anleyssen commented 1 year ago

The suggested changes of Els Lommelen are made in HT31xx LSVI. Other 'to do's' can't be solved at the moment; so @ToonHub, you can merge this branch with the master.