Closed anleyssen closed 1 year ago
Some suggestions for the table site_caractheristics:
In the LSVI-calculation you use '1-out-all-out' for the aggregation. If you want to use the method that was used for the HR-reporting, you sould use Aggregatiemethode = "RapportageHR".
To make the code better readable I suggest to always start a new line after %>%
Suggested changes in HT31xx data preparation are made:
Some minor changes in HT31xx_LSVI (text edits) are also made. Can @ElsLommelen also review the code for LSVI-calculation?
The suggested changes of Els Lommelen are made in HT31xx LSVI. Other 'to do's' can't be solved at the moment; so @ToonHub, you can merge this branch with the master.
I managed to run the script without any errors and the code is documented quite well . Good!
But I still have some comments and suggestions. See below.