inbo / n2khab

R package with preprocessing functions and standard reference data for Flemish Natura 2000 (N2K) habitat (HAB) analyses
https://inbo.github.io/n2khab
GNU General Public License v3.0
2 stars 1 forks source link

scheme_types: update typegroup memberships GW_05.1_terr #116

Closed florisvdh closed 3 years ago

florisvdh commented 3 years ago

I understood this is work done by @w-jan and @DriesAdriaens . Thank you!

Further comments are welcome before I merge.

These seem to be the changes in the resulting dataframe (with working directory at misc/generate_textdata and checked out on scheme_types branch):

> library(git2rdata)
> library(magrittr)
> scheme_types_new <- read_vc("scheme_types", "../../inst/textdata/")
> system("git show origin/dev_0.5.0:../../inst/textdata/scheme_types.tsv", intern = TRUE) %>% 
+     writeLines(file.path(tempdir(), "scheme_types.tsv")) 
> system("git show origin/dev_0.5.0:../../inst/textdata/scheme_types.yml", intern = TRUE) %>% 
+     writeLines(file.path(tempdir(), "scheme_types.yml")) 
> scheme_types_old <- read_vc("scheme_types", tempdir())

> # LINES PRESENT ONLY BEFORE
> scheme_types_old %>% 
+     dplyr::anti_join(scheme_types_new, by = c("scheme", "type", "typegroup"))
        scheme    type           typegroup
1 GW_05.1_terr 1310_zv GW_05.1_terr_group1
2 GW_05.1_terr   rbbsm GW_05.1_terr_group3
3 GW_05.1_terr 6430_mr GW_05.1_terr_group2

> # LINES PRESENT ONLY AFTER
> scheme_types_old %>% 
+     dplyr::anti_join(scheme_types_new, ., by = c("scheme", "type", "typegroup"))
        scheme    type           typegroup
1 GW_05.1_terr 1310_zv GW_05.1_terr_group4
2 GW_05.1_terr   rbbsm GW_05.1_terr_group2
3 GW_05.1_terr 6430_mr GW_05.1_terr_group3
Source code only ```r library(git2rdata) library(magrittr) scheme_types_new <- read_vc("scheme_types", "../../inst/textdata/") system("git show origin/dev_0.5.0:../../inst/textdata/scheme_types.tsv", intern = TRUE) %>% writeLines(file.path(tempdir(), "scheme_types.tsv")) system("git show origin/dev_0.5.0:../../inst/textdata/scheme_types.yml", intern = TRUE) %>% writeLines(file.path(tempdir(), "scheme_types.yml")) scheme_types_old <- read_vc("scheme_types", tempdir()) # LINES PRESENT ONLY BEFORE scheme_types_old %>% dplyr::anti_join(scheme_types_new, by = c("scheme", "type", "typegroup")) # LINES PRESENT ONLY AFTER scheme_types_old %>% dplyr::anti_join(scheme_types_new, ., by = c("scheme", "type", "typegroup")) ```
DriesAdriaens commented 3 years ago

These changes are exactly what we decided to change with respect to the typegroup memberships.