Changes needed in read_habitatmap_xxx() - Githubissues

inbo / n2khab

R package with preprocessing functions and standard reference data for Flemish Natura 2000 (N2K) habitat (HAB) analyses

https://inbo.github.io/n2khab

GNU General Public License v3.0

2 stars 1 forks source link

Changes needed in read_habitatmap_xxx() #117

Closed florisvdh closed 3 years ago

florisvdh commented 3 years ago

For reference, based on https://github.com/inbo/n2khab-preprocessing/pull/50:

read_habitatmap() has been verified by Toon and myself to work with habitatmap version habitatmap_2020. No changes needed AFAIK.
- except the literature reference (documentation)
read_habitatmap_stdized() & read_habitatmap_terr():
- check that they work for the new versions
- minor documentation update needed to make clear that unique records in the second layer are identified by polygon_id, type, certain.
- polygon_id, type, certain will be the first columns returned for the second layer, in case of the latest data source version. This is to be updated in the documentation (Value section); other order in previous versions can be ignored here (perhaps it can be mentioned this is 'for the latest data source version').
- version argument will need to be updated to latest version tag
- you may want to add a note on the interpretation of phab for code combinations from one column of the original habitatmap

@cecileherr feel free to update or discuss.

florisvdh commented 3 years ago

Solved by #139, #140