inbo / n2khab

R package with preprocessing functions and standard reference data for Flemish Natura 2000 (N2K) habitat (HAB) analyses
https://inbo.github.io/n2khab
GNU General Public License v3.0
2 stars 1 forks source link

Non-working URLs in documentation #129

Closed florisvdh closed 3 years ago

florisvdh commented 3 years ago

When running rcmdcheck::rcmdcheck(args = c("--as-cran", "--no-manual")) rather than RStudio's devtools::check(args = c('--no-manual','--as-cran')), a more extended CRAN incoming feasibility note is returned than on GH Actions.

Several URLs cannot be reached, among which those that require login. To be solved.

With n2khab at b7cf204:

N  checking CRAN incoming feasibility (2m 14.1s)
   Maintainer: ‘Floris Vanderhaeghe <floris.vanderhaeghe@inbo.be>’

   New submission

   Version contains large components (0.4.0.9000)

   Found the following (possibly) invalid URLs:
     URL: https://cran.r-project.org/web/packages/digest/index.html
       From: man/checksum.Rd
       Status: 200
       Message: OK
       CRAN URL not in canonical form
     URL: https://cran.r-project.org/web/packages/openssl/index.html
       From: man/checksum.Rd
       Status: 200
       Message: OK
       CRAN URL not in canonical form
     URL: https://github.com/inbo/n2khab-preprocessing/blob/master/src/complete_reproducible_workflow.R
       From: inst/doc/v020_datastorage.html
       Status: 404
       Message: Not Found
     URL: https://github.com/inbo/n2khab/pull/73/commits/7ce3b32
       From: NEWS.md
       Status: 404
       Message: Not Found
     URL: https://gitlab.com/florisvdh/n2khab-mne-selections
       From: man/scheme_types.Rd
             man/schemes.Rd
       Status: 503
       Message: Service Unavailable
     URL: https://http://www.geopunt.be/catalogus/datasetfolder/10e87ad3-8235-40e0-8269-42c3c96a884d
       From: man/read_watersurfaces_hab.Rd
       Status: Error
       Message: libcurl error code 6:
            Could not resolve host: http
     The canonical URL of the CRAN page for a package is 
       https://CRAN.R-project.org/package=pkgname

Sidenote: an idea to solve the note about large version numbers, useful after releasing 0.5.0, is using '900' instead of '9000' - based on a hint in https://github.com/inbo/protocolhelper/pull/43#issuecomment-804701527. Will add that to the checklist discussion after solving the URLs. First trials demonstrate that it would work.

florisvdh commented 3 years ago

After a first wave of URL updates (2b2d226), it appears that the fixed Geopunt URL still doesn't work (link in documentation of read_watersurfaces_hab()). It seems that version watersurfaces_v1.0 has disappeared from Geopunt (https://www.geopunt.be/catalogus/search?facet=catalog&q=watervlakken).

N  checking CRAN incoming feasibility (1m 59.8s)
   Maintainer: ‘Floris Vanderhaeghe <floris.vanderhaeghe@inbo.be>’

   New submission

   Version contains large components (0.4.0.9000)

   Found the following (possibly) invalid URLs:
     URL: http://www.geopunt.be/catalogus/datasetfolder/10e87ad3-8235-40e0-8269-42c3c96a884d
       From: man/read_watersurfaces_hab.Rd
       Status: 404
       Message: Not Found

Will replace by version-independent DOI from Zenodo.