search

inbo / n2khab

R package with preprocessing functions and standard reference data for Flemish Natura 2000 (N2K) habitat (HAB) analyses
https://inbo.github.io/n2khab
GNU General Public License v3.0
2 stars 1 forks source link

change code and documentation for read_habitatmap_stdized and read_wa… #37

Closed ToonHub closed 4 years ago

ToonHub commented 5 years ago

…tersurfaces_hab as we no longer use the term 'patch'

The adapted functions will no longer work with older versions of habitatmap_stdized and watersurfaces_hab. It will give an error.

Should we change the function so it can also read older versions (that contain the layer 'habitatmap_stdized_patches') and give a warning if older versions are read?

florisvdh commented 5 years ago

BTW, in DESCRIPTION you best update the dev version number to 0.0.3.9037 (37 being the PR number)

ToonHub commented 4 years ago

I did 1. en 2. @florisvdh can you check the new versions on Zenodo. After we do 3., in Zenodo we will have tot refer to the commit corresponding with the new versions

florisvdh commented 4 years ago

I'm looking at it. Can you also make a pull request in n2khab-preprocessing, regarding the removal of 7220?

florisvdh commented 4 years ago

@ToonHub I checked both gpkg files from Zenodo, they are OK! I emailed you some remarks on metadata.

Your updates to n2khab look good to me. One addition is proposed in PR #41

I'm in the process of uploading the new version of habitatmap_terr, I will keep you informed.

florisvdh commented 4 years ago

@ToonHub you can have a look if the metadata of https://doi.org/10.5281/zenodo.3540740 are OK to you (note, @w-jan already reviewed the actual data). After that, this PR can be merged to master!

ToonHub commented 4 years ago

OK!