inbo / n2khab

R package with preprocessing functions and standard reference data for Flemish Natura 2000 (N2K) habitat (HAB) analyses
https://inbo.github.io/n2khab
GNU General Public License v3.0
2 stars 1 forks source link

Minor issue in https://inbo.github.io/n2khab/reference/env_pressures.html #98

Closed cecileherr closed 3 years ago

cecileherr commented 3 years ago

Under:

Source The latest worksheet of this googlesheet. Currently, the googlesheet and the data source are both kept up-to-date.

The link to the google sheet is wrong, it should probably be: https://docs.google.com/spreadsheets/d/1aVUQWQlaL3k5hjuwyH-8c0lW7hjIkPz8VZbNgyMlN0A/edit?usp=sharing

(I haven't any active branch yet, so I post this no to forget, but I might correct this by myself as soon as I start working on this package ;-) )

florisvdh commented 3 years ago

Thanks for detecting. Apparently there is some trouble caused by Gdrive / InSync file management; it appears that this gsheet had been moved to the trash folder... It's restored and the link should work again. I'll have a look if other GDrive documents are affected (< 30 days left ...) and meanwhile try to put some backup mechanism in place.

Nevertheless, it might be a good idea to link to the document that you propose.

florisvdh commented 3 years ago

Actually the currently referred link effectively is the source: it is where we add new versions and it is indeed the googlesheet that is read by the code that updates the env_pressures data source (see these lines) - more specifically the latest worksheet (as said in the documentation).

The other googlesheet (the link that you mention) is always a copy which we update to the latest version, for easier reference. So it would also work as source, but currently that is not implemented.

@cecileherr given these findings I'm inclined to leave worklows & documentation as-is, but you may feel otherwise: does this solve the issue for you?

w-jan commented 3 years ago

May be a rather silly question: now when you open the gsheet, the oldest version is being shown. The latest version is far to the right. Inversion would be a solution, may I do that ?

Op ma 14 dec. 2020 om 18:02 schreef Floris Vanderhaeghe < notifications@github.com>:

Actually the currently referred link https://docs.google.com/spreadsheets/d/1PH6InqJk0ijQF_N7v7IZjarijlqHRBCKhTbDn44skZU effectively is the source: it is where we add new versions and it is indeed the googlesheet that is read by the code that updates the env_pressures data source (see these https://github.com/inbo/n2khab/blob/63d3c3ebea742e8d4beb0ce38b5ab2263b82a246/misc/generate_textdata/20_env_pressures.Rmd#L8-L14 lines) - more specifically the latest worksheet (as said in the documentation).

The other googlesheet (the link that you mention) is always a copy which we update to the latest version, for easier reference. So it would also work as source, but currently that is not implemented.

@cecileherr https://github.com/cecileherr given these findings I'm inclined to leave worklows & documentation as-is, but you may feel otherwise: does this solve the issue for you?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/inbo/n2khab/issues/98#issuecomment-744576103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIOMT4Z7RNJSRDD74ZRNQTSUZAJ3ANCNFSM4UWPIP6A .

-- Jan Wouters Onderzoeker

Vlaamse Overheid INSTITUUT VOOR NATUUR- EN BOSONDERZOEK Team Milieu en Klimaat T +32 471 33 93 94

Herman Teirlinckgebouw, Havenlaan 88 bus 73, B-1000 Brussel www.inbo.be //////////////////////////////////////////////////////////// ///////////////////////////////

florisvdh commented 3 years ago

You're welcome to reverse the worksheet order @w-jan :+1: , good idea. Let me know when that's done, I'll create another issue for updating the R code (take first, not last worksheet).

w-jan commented 3 years ago

Ok done ;-)

Op ma 14 dec. 2020 om 18:14 schreef Floris Vanderhaeghe < notifications@github.com>:

You're welcome to reverse the worksheet order @w-jan https://github.com/w-jan 👍 , good idea. Let me know when that's done, I'll create another issue for updating the R code (take first, not last worksheet).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/inbo/n2khab/issues/98#issuecomment-744583512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIOMTYTVCHPQFP565G4GBTSUZBXRANCNFSM4UWPIP6A .

-- Jan Wouters Onderzoeker

Vlaamse Overheid INSTITUUT VOOR NATUUR- EN BOSONDERZOEK Team Milieu en Klimaat T +32 471 33 93 94

Herman Teirlinckgebouw, Havenlaan 88 bus 73, B-1000 Brussel www.inbo.be //////////////////////////////////////////////////////////// ///////////////////////////////

cecileherr commented 3 years ago

@cecileherr given these findings I'm inclined to leave worklows & documentation as-is, but you may feel otherwise: does this solve the issue for you?

As long as it works: ok for me to keep using the work version! (ps: I removed the unnecessary copy of the last version on our drive)

florisvdh commented 3 years ago

OK, then I'll close the issue here. Regarding backups if GDrive leads to misery - there's always a chance it seems:

Feel free to continue discussion below.