inbo / niche_vlaanderen

Python package to run the NICHE Vlaanderen model
https://inbo.github.io/niche_vlaanderen/
MIT License
5 stars 2 forks source link

Add code table overwriting to advanced_usage.ipynb #165

Closed DriesAdriaens closed 6 years ago

DriesAdriaens commented 6 years ago

@johanvdw I'm not confident that the addition to the jupyter notebook is ok ... It worked, but I'm not sure about the correct rendering.

johanvdw commented 6 years ago

Are you sure you want to change this: https://github.com/inbo/niche_vlaanderen/pull/165/files#diff-dec2aad1bbbac876e838452e24def595R209

In general you should try doing (from the "kernel" menu in jupyter: Restart and run all cells to check if everything works as expected, and then Restart and clear all results before committing. That way all output is removed from the file and built again when making the documentation.

On Mon, May 7, 2018 at 5:04 PM, DriesAdriaens notifications@github.com wrote:

@johanvdw https://github.com/johanvdw I'm not confident that the addition to the jupyter notebook is ok ... It worked, but I'm not sure about the correct rendering.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/inbo/niche_vlaanderen/pull/165#issuecomment-387094880, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1AUi2YdF97pEzw-Q0NYMnAGOpQVqKhks5twGJ7gaJpZM4T1ID6 .

DriesAdriaens commented 6 years ago

OK, I will try again then. This pull request can then be closed?