search

inbo / niche_vlaanderen

Python package to run the NICHE Vlaanderen model
https://inbo.github.io/niche_vlaanderen/
MIT License
5 stars 2 forks source link

Working with rasters with asymmetrical (rectangular) cells? #204

Closed cecileherr closed 5 years ago

cecileherr commented 5 years ago

Niche Python Package question

Can the model be used with input rasters with asymmetrical cells? (not square, but rectangular ones). I do not have the needed input files (yet) to test it by myself (but if nobody knows the answer I'll make them and give it a try) Thanks in advance!

johanvdw commented 5 years ago

I have not tested this, but I'm quite sure that this should not be an issue. All grids do have to use the same system though, we don't reproject.

cecileherr commented 5 years ago

OK, thanks! I will try it, report the result here and close the issue when it is done

cecileherr commented 5 years ago

No extensive testing yet, but the first tests were succesful, so I close the issue

johanvdw commented 5 years ago

I think we should consider creating a 1.0.1 release so users will install these fixes by default.

On Mon, Jun 24, 2019 at 11:30 AM Cécile Herr notifications@github.com wrote:

Closed #204 https://github.com/inbo/niche_vlaanderen/issues/204.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/inbo/niche_vlaanderen/issues/204?email_source=notifications&email_token=AAGUAUU52ZKLPNK24QJYFPTP4CH3JA5CNFSM4HDSVSS2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSEHGF7I#event-2433639165, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGUAUUG55GYHGWDR6GRJITP4CH3JANCNFSM4HDSVSSQ .

stijnvanhoey commented 5 years ago

which fixes? As this just seem to work without adjustments?

johanvdw commented 5 years ago

@stijnvanhoey : this fix: https://github.com/inbo/niche_vlaanderen/commit/c64d8659d0ef69594a545c1e906cdf5a9c9e9097

cecile is using master and not a released version.

Apart from that some smaller issues have been dealt with, mostly warnings from packages we depend on.

stijnvanhoey commented 5 years ago

Thanks for clarifying. I agree, bump new release would be good!

cecileherr commented 5 years ago

Yes, we will have a new official NICHE project soon that would require the corrected version. It would be nice to be able to use an official version.

But please note there might be a small bug (abiotic tiffs not always exported) that I want to check today or tomorrow, so maybe beter to wait until We know if there is another small correction needed?

cecileherr commented 5 years ago

But please note there might be a small bug (abiotic tiffs not always exported) that I want to check today or tomorrow, so maybe beter to wait until we know if there is another small correction needed?

I checked and good news: I found no bug, so OK for a new release with the fixes for the small shift in spatial overlap