inbo / niche_vlaanderen

Python package to run the NICHE Vlaanderen model
https://inbo.github.io/niche_vlaanderen/
MIT License
5 stars 0 forks source link

Validation: definition vegetation_columns #313

Closed cecileherr closed 1 year ago

cecileherr commented 1 year ago

The selection of the vegetation columns in validation.py vegetation_columns = columns[columns.str.upper().str.startswith('HAB')] induces errors because there are other fields starting with 'HAB'.

In the official version of the habitat map we have a field named HABLEGENDE/HABlegende (the letter case apparently depends on the version, I checked for 2014, 2016, 2018, 2020). The test dataset for Brasschaat uses an internal version of the habitat map that does not contain this HABLEGENDE field.

Of course we cannot cover avery possible field starting with HAB that a user might ever want to add to his/her shape, but I think we should at least allow HABLEGENDE/HABlegende to be present in the shape (since this field appears in the official habitat map)

johanvdw commented 1 year ago

check for HAB[1-9]