inbo / protocolhelper

Helper functions and templates to manage the INBO/protocols repository.
https://inbo.github.io/protocolhelper/
GNU General Public License v3.0
5 stars 0 forks source link

edit button fails #110

Closed hansvancalster closed 1 year ago

hansvancalster commented 1 year ago

For instance, the following link fails: https://github.com/inbo/protocolsource/edit/main/source/sfp/4_vegetation/sfp_403_nl_vegopname_lsvi_3260/%s

probably because the %s doesn't resolve to a corresponding .Rmd file when we render markdown chapter files into a single html page?

If so, better remove this feature.

hansvancalster commented 1 year ago

dropping the %s could be a temporary workaround (a final solution is using quarto instead of bookdown - which is a long-term goal): https://github.com/inbo/protocolsource/edit/main/source/sfp/4_vegetation/sfp_403_nl_vegopname_lsvi_3260/

this redirects to https://github.com/inbo/protocolsource/tree/main/source/sfp/4_vegetation/sfp_403_nl_vegopname_lsvi_3260

which gives you a list of all Rmd files. Clicking one of the files and in the next screen press the "pencil / edit" button allows edits on GitHub.

hansvancalster commented 1 year ago

dropping the %s could be a temporary workaround (a final solution is using quarto instead of bookdown - which is a long-term goal): https://github.com/inbo/protocolsource/edit/main/source/sfp/4_vegetation/sfp_403_nl_vegopname_lsvi_3260/

this redirects to https://github.com/inbo/protocolsource/tree/main/source/sfp/4_vegetation/sfp_403_nl_vegopname_lsvi_3260

which gives you a list of all Rmd files. Clicking one of the files and in the next screen press the "pencil / edit" button allows edits on GitHub.

Unfortunately, this idea doesn't work (%s must be present). So I will remove the edit button.