inbo / reporting-rshiny-grofwildjacht

Rshiny app for grofwildjacht
https://grofwildjacht.inbo.be/
MIT License
1 stars 1 forks source link

[Feature] Tabel kencijfers #438

Closed SanderDevisscher closed 10 months ago

SanderDevisscher commented 11 months ago

Suggested Title

Tabel kencijfers

INFO:

ANB asked us to add the following information in table form (1 row per item):

1 both afschot & observations 2 I suggest we add a threshold slider for observations allowing the user to decide how much weight they give to the observations. Default 1? min: 1 -> max: 10 ?

Position

*dummy data

Additional Options

Some related questions: @mvarewyck how much time would you need to add this table ? @mvarewyck is it possible to add this this year or at the latest early next year ? @mvarewyck what is your current day cost ? I need this info to because ANB indicated they are willing to pay for additional features.

@jimcasaer @RuttenAnneleen @LynnPallemaerts can you help me with good descriptions ? Do you have any additional suggestions/remarks ?

mvarewyck commented 11 months ago

Some related questions: @mvarewyck how much time would you need to add this table ?

3 days

@mvarewyck is it possible to add this this year or at the latest early next year ?

Yes we can.

@mvarewyck what is your current day cost ? I need this info to because ANB indicated they are willing to pay for additional features.

Tobias will contact you about this (PM).

SanderDevisscher commented 11 months ago

I'll for finances from ANB for extra table

Yingjie-ZhangOA commented 11 months ago

Screenshot 2023-12-05 at 10 35 30 Screenshot 2023-12-05 at 10 34 53

Yingjie-ZhangOA commented 10 months ago

In branch feature#438 the following features are implemented

Screenshot 2023-12-07 at 09 44 37
SanderDevisscher commented 10 months ago
  • for "afschot", slide range is 1 to max(10, maximum of the afschot aantal). This is pure cosmetic, as in the current data, the "afschot aantal" is always 1.

The fact "afschot aantal" is 1 for every commune is weird! How is this calculated ?

SanderDevisscher commented 10 months ago

Other changes look good

Yingjie-ZhangOA commented 10 months ago

I don't have the data prior to process @mvarewyck can you double check this?

> unique(geoData[geoData$dataSource == "afschot", "aantal"])
1
SanderDevisscher commented 10 months ago

One tiny remark, we should be consequent with gemeentes & gemeenten both are viable but it should be on or the other. I would opt for gemeentes, meaning "Totaal aantal gemeenten" should become "Totaal aantal gemeentes"

SanderDevisscher commented 10 months ago

@jimcasaer @LynnPallemaerts @RuttenAnneleen what do you guys think about this text (and layout)?:

jimcasaer commented 10 months ago

het onderste lijkt met niet logisch je zou dan drie kleuren moeten hebben (en liefst geen groen)

mvarewyck commented 10 months ago

I don't have the data prior to process @mvarewyck can you double check this?

> unique(geoData[geoData$dataSource == "afschot", "aantal"])
1

It is correct that for geoData the aantal is always 1, as each row represents a single record in the data ( in contrast to waarnemingen). So, for the kencijfers table, we should now first calculate the total per region level of interest (i.e. calculating the sum of 'aantal' for each province/municipality selected).

Note: Previously this was no problem, as there was no threshold, so the actual 'afschot aantal' did not matter.

Yingjie-ZhangOA commented 10 months ago

I don't have the data prior to process @mvarewyck can you double check this?

> unique(geoData[geoData$dataSource == "afschot", "aantal"])
1

It is correct that for geoData the aantal is always 1, as each row represents a single record in the data ( in contrast to waarnemingen). So, for the kencijfers table, we should now first calculate the total per region level of interest (i.e. calculating the sum of 'aantal' for each province/municipality selected).

Note: Previously this was no problem, as there was no threshold, so the actual 'afschot aantal' did not matter.

I see, thanks for spotting, I'll adapt the code.

SanderDevisscher commented 10 months ago

@jimcasaer @LynnPallemaerts @RuttenAnneleen what do you guys think about this text (and layout)?: