Closed SanderDevisscher closed 10 months ago
Some related questions: @mvarewyck how much time would you need to add this table ?
3 days
@mvarewyck is it possible to add this this year or at the latest early next year ?
Yes we can.
@mvarewyck what is your current day cost ? I need this info to because ANB indicated they are willing to pay for additional features.
Tobias will contact you about this (PM).
I'll for finances from ANB for extra table
In branch feature#438 the following features are implemented
Slider input for both data source "waarnemingen" and "afschot", data is filtered >=
threshold
max(10, maximum of the afschot aantal)
. This is pure cosmetic, as in the current data, the "afschot aantal" is always 1.
If a municipality in the table exclusively from data source "waarnemingen", it gets a green background (color picked from inbo theme)
The downloaded data now contains also the count for "waarnemingen" and "afschot" if available
In the report, the table is present the same way as in the application
[ ] add detailed explanation of the table in "uiText.csv" (row: plotFunction "F18_8", column: "dash") @SanderDevisscher
- for "afschot", slide range is 1 to
max(10, maximum of the afschot aantal)
. This is pure cosmetic, as in the current data, the "afschot aantal" is always 1.
The fact "afschot aantal" is 1 for every commune is weird! How is this calculated ?
Other changes look good
I don't have the data prior to process @mvarewyck can you double check this?
> unique(geoData[geoData$dataSource == "afschot", "aantal"])
1
One tiny remark, we should be consequent with gemeentes & gemeenten both are viable but it should be on or the other. I would opt for gemeentes, meaning "Totaal aantal gemeenten" should become "Totaal aantal gemeentes"
@jimcasaer @LynnPallemaerts @RuttenAnneleen what do you guys think about this text (and layout)?:
het onderste lijkt met niet logisch je zou dan drie kleuren moeten hebben (en liefst geen groen)
I don't have the data prior to process @mvarewyck can you double check this?
> unique(geoData[geoData$dataSource == "afschot", "aantal"]) 1
It is correct that for geoData the aantal
is always 1, as each row represents a single record in the data (
in contrast to waarnemingen). So, for the kencijfers table, we should now first calculate the total per region level of interest (i.e. calculating the sum of 'aantal' for each province/municipality selected).
Note: Previously this was no problem, as there was no threshold, so the actual 'afschot aantal' did not matter.
I don't have the data prior to process @mvarewyck can you double check this?
> unique(geoData[geoData$dataSource == "afschot", "aantal"]) 1
It is correct that for geoData the
aantal
is always 1, as each row represents a single record in the data ( in contrast to waarnemingen). So, for the kencijfers table, we should now first calculate the total per region level of interest (i.e. calculating the sum of 'aantal' for each province/municipality selected).Note: Previously this was no problem, as there was no threshold, so the actual 'afschot aantal' did not matter.
I see, thanks for spotting, I'll adapt the code.
@jimcasaer @LynnPallemaerts @RuttenAnneleen what do you guys think about this text (and layout)?:
Suggested Title
Tabel kencijfers
INFO:
ANB asked us to add the following information in table form (1 row per item):
1 both afschot & observations 2 I suggest we add a threshold slider for observations allowing the user to decide how much weight they give to the observations. Default 1? min: 1 -> max: 10 ?
Position
Description/Disclaimer
Datacolumns
Filters
!"waarnemingen" %in% Bron
)Code example
Layout example
*dummy data
Additional Options
Some related questions: @mvarewyck how much time would you need to add this table ? @mvarewyck is it possible to add this this year or at the latest early next year ? @mvarewyck what is your current day cost ? I need this info to because ANB indicated they are willing to pay for additional features.
@jimcasaer @RuttenAnneleen @LynnPallemaerts can you help me with good descriptions ? Do you have any additional suggestions/remarks ?