Updates v0.3.4

[SanderDevisscher]

@mvarewyck is this PR ready for review ?

[mvarewyck]

@mvarewyck is this PR ready for review ?

Yes!

[SanderDevisscher]

@mvarewyck which column do you use for type on FIGUUR: Gerapporteerd aantal embryo's voor vrouwelijke damherten per jaar? With damhert we get only onbekend while this should be Kalf (V), Smaldier, Hinde & Onbekend ?

Same for Edelhert

[mvarewyck]

@mvarewyck which column do you use for type on FIGUUR: Gerapporteerd aantal embryo's voor vrouwelijke damherten per jaar? With damhert we get only onbekend while this should be Kalf (V), Smaldier, Hinde & Onbekend ?

Same for Edelhert

Good point, we retain the female choices from column type_comp 'by hand' in the code. Currently (mistakenly) the ones from 'Wild zwijn' are taken. So you want c("Kalf (v)", "Smaldier", "Hinde", "Onbekend") choices for both 'Damhert' and 'Edelhert'?

> table(droplevels(ecoData$type_comp[ecoData$wildsoort == "Damhert"]))

Kalf (v) Kalf (m) Smaldier  Spitser    Hinde     Hert Onbekend 
      65       78      126      148      161      188       19 
> table(droplevels(ecoData$type_comp[ecoData$wildsoort == "Edelhert"]))

Kalf (v) Kalf (m) Smaldier  Spitser    Hinde     Hert Onbekend 
      17        8        7       18       11       20        4 

[SanderDevisscher]

Yes

[jimcasaer]

I guess so yes, maybe best to check (to be 200% sure) with @LynnPallemaerts @emiliegelaude

[mvarewyck]

@SanderDevisscher while comparing the table for WBE with the one for grofwild I saw that we didn't include a row for 'Onbekend'. Is it fine if I add a row like below? I think this is better when users compare Total numbers with the graph above in the app.

[SanderDevisscher]

@SanderDevisscher while comparing the table for WBE with the one for grofwild I saw that we didn't include a row for 'Onbekend'. Is it fine if I add a row like below? I think this is better when users compare Total numbers with the graph above in the app.

Yes its fine

[SanderDevisscher]

Everything seems to work like it should