search

inbo / reporting-rshiny-grofwildjacht

Rshiny app for grofwildjacht
https://grofwildjacht.inbo.be/
MIT License
1 stars 1 forks source link

[BUG] error in data check for wildschade #472

Open SanderDevisscher opened 4 months ago

SanderDevisscher commented 4 months ago

Describe the bug when running testS3() we get the following error:

Error in testS3() : 
</br>Please check data in S3 bucket: inbo-wbe-uat-data </br>Following tests in tests/testData.R failed. Please fix in order of occurrence.</br> <h4>Test: Schade data & metadata </h4>Error message:</br> `schadeData` inherits from `'tbl_df'/'tbl'/'data.frame'` not `'character'`.</br>WildSchade_georef.csv </br> <h4>Test: Schade data & metadata </h4>

I think this is a relic of the transfer to parquet files. @mvarewyck can you confirm the data for the app is extracted from the wildschade parquet file ?

Expected behavior Only the warning is shown

mvarewyck commented 4 months ago

@mvarewyck can you confirm the data for the app is extracted from the wildschade parquet file ?

Yes, here The test was failing because after transforming the wildschade file to a parquet file we load the data as a data.frame rather than sf object