Closed ElsLommelen closed 2 years ago
I'm afraid I did something wrong: I cloned the repo locally, made a branch, pushed a commit and made a PR. After that, I noticed the PR was made in the main repo on citation-style-language and not in this fork. How can I solve this mistake? Or is this just the way it works?
It's because the target of a fork's PR is the upstream repo by default. The easiest for now is to turn it into a draft PR (which I cannot), then I can add a few more changes (next week or so) to include in a new release. The upside of a draft PR to the upstream repo is that some automated checks are run already. The alternative is to change the target repo of the PR to the current repo, which you can also do I think, at the top of the PR page, so that we can finish the PR in this repo before switching target repo to upstream again.
@ElsLommelen your implementation of the s. d.
to s.d.
overruling in #5634 looks fine indeed. :+1:
In an effort to make a next release of the INBO CSL style file (long overdue task), I was looking whether other things needed to be changed here, for French.
@cecileherr @ElsLommelen You probably already checked the citation & bibliographic output in French, see clickable details at the end of this post? These are the bibliographic data from https://inbo.github.io/inbomd_examples/citation_style/en/index.html (where English is rendered).
I was surprised that the CSL term in
is rendered in fr-FR as 'in' and not as 'dans', but it appears it must be regarded as the Latin in, as discussed in https://github.com/citation-style-language/locales/pull/23 and https://forums.zotero.org/discussion/4738/4/#Item_29. However in fr-CA it is translated to 'dans' nonetheless.
Regarding the space between s.
and d.
, it might be argued that it should be removed in the above referred (central) CSL locale files. The presence or absence of a space for the short form of the no date
term seems to vary according to language, which looks like an inconsistency, but perhaps abbreviation 'defaults' (spacing/no spacing in abbreviations) do differ between languages and countries. @cecileherr if you're convinced it's better to remove this space (and perhaps also for other terms) in the CSL source, feel free to make an issue at https://github.com/citation-style-language/locales. The role of CSL locale files is explained in https://docs.citationstyles.org/en/stable/specification.html#locale and https://docs.citationstyles.org/en/stable/specification.html#locale-files-structure. Changing it there, if appropriate, would 'solve' this for any CSL style when a style is used for rendering French.
I checked the output, and the only thing I would change, is indeed removing the space in s. d.
for consistency between languages. But I'm not an expert in french citation styles (I only checked some journal articles), so I leave it up to @cecileherr to propose additional changes.
It is becoming quite a specialized discussion, I am afraid a native speaker's feeling will not be enough to give a definitive answer ;-)
So for what it is worth:
French language tends to use more spaces than Dutch or English, so I wasn't even surprised to see s. d.
(with a non breaking space thus) instead of s.d.
in the French version of the csl. After a bit of research it seems both forms are used but apparently the version without a space seems to be more common (?). So ok for me to replace it by s.d.
. In the French csl I only see one more candidate for a space removal: sub verbo (sing & plural), and again I can find both forms s.v.
and s. v.
in the literature (note that the other  
in the French csl - used with quotes - are definitely needed in French)
@florisvdh: regarding your question about changing the official csl for French: I am afraid I am not qualified to make really relevant suggestions (is there a librarian in the room? ;-) )
Thanks @cecileherr for shedding light on the use of spaces en français. I conclude:
s.d.
is often used without space as well, it is OK to keep this change in our style file. I'll move on with our CSL style file release, then.Closed by citation-style-language#5634
Similarly to the Dutch and English style, I would propose to also omit the space in the French style for reports of the research institute for nature and forest.