search

inbo / tutorials

A collection of technical tutorials for INBO (and anyone who's interested)
https://inbo.github.io/tutorials/
Creative Commons Attribution 4.0 International
22 stars 9 forks source link

r_gbif_checklist: some fixes #320

Closed florisvdh closed 1 year ago

florisvdh commented 1 year ago

Description

Notably, this updates the date format; currently renders as:

afbeelding

Plus some extra fixes.

I did the edit online in the Rmd file. @damianooldoni can you knit to md and add the extra commit please?

Previewing the pull request

Thanks to GitHub Actions, an artifact (=zip file) of the rendered website is automatically created for each pull request. This provides a way to preview how these updates will look on the website, useful to contributors and reviewers.

Instructions to preview the updated website

1) On the PR page, you can find a "details" link under "checks - On PR, build the site and ...". Go there, click on the top link in the left sidebar ("Summary"), and download the generated artifact at the bottom of the page. 2) Decompress it and make sure the target directory is called 'tutorials' (you may need to rename it) 3) From the parent directory (just above the tutorials folder you created/renamed), run python -m http.server 8887, or launch the Google Chrome Web Server app and point it at the parent directory. 4) Point your browser to http://localhost:8887/tutorials. 5) Review the updated website. As a contributor, you can push extra commits to update the PR. As a reviewer, you can accept/refuse/comment the PR.

Note: for step 3, you can use any other simple HTTP server to serve the current directory if you don't have a Python 3 environment or Google Chrome available.

damianooldoni commented 1 year ago

Thanks @florisvdh! I got also some nice inputs from @peterdesmet. I will add all of them in this PR and then I will knit it. Thank you all 👍

damianooldoni commented 1 year ago

Copy pasting the improvements proposed by @peterdesmet for better tracking while committing them:

  1. ik zou ook taxonID vermelden
  2. done by GBIF automatically behind the scenes (to remove: while) when publishing the checklist.
  3. Bij je nerdy touch is er een numbered list die niet mooi rendert, wrsch door ontbrekende lege lijn tussen paragraaf en punt “1. taxonomic information:”

De titel is ook iets nauwer in scope dan wat je uitlegt, dus misschien even hinten in de description

Titel: Get species checklist data from GBIF (to remove: via) with rgbif Description: How to use rgbif function name_usage() to get species checklist data from GBIF as well as some other rgbif tips.

damianooldoni commented 1 year ago

@peterdesmet, @florisvdh: I reviewed myself 😄 If you want have a final look please do it. I let you merge the PR afterwards.

florisvdh commented 1 year ago

Looks OK, thanks!

@peterdesmet, if you want to re-review, then it's up to you to merge.

BTW: JSON and XML render nicely out of the box in Firefox:

afbeelding