inbo / whip

✅ Human and machine-readable syntax to express specifications for data
MIT License
7 stars 0 forks source link

redundant evaluation test `equals` #2

Closed stijnvanhoey closed 7 years ago

stijnvanhoey commented 7 years ago

As the test equals can be expressed by a combination of the terms min and max, this evaluation test is rather redundant.

e.g.

equals: 10

is equal to this test description:

min: 10
max: 10

This is similar for the length test (combination of minlength and maxlength.

It could be considered useful to keep this as a separate test out of convenience for the user. Still, when equals is considered, one could argue to include equalsdate and equalslength as well.

Therefore, I would leave equals out as a separate test option.

peterdesmet commented 7 years ago

Agreed. Also, by removing it, it cannot create confusion with allowed.

stijnvanhoey commented 7 years ago

done!