search

inboundnow / inbound-mailer-retired

0 stars 1 forks source link

Color pickers added from ACF Pro #46

Closed daprela closed 8 years ago

daprela commented 9 years ago

I don't know if we can do anything about this, since it comes from a third party plugin. There are basically two problems with color pickers.

Sometimes values from color pickers are not saved, and when you open a previously saved email and preview it all backgrounds come white, which is the default color that I've assigned to them. This is not sistematic, and I've not been able to find a way to replicate this behavior consistently.

The other problem is that even when values are saved (and you know because the email preview is correct), in the edit page all color pickers appear grey, they don't show their value. Even when you create a new email they don't even show their default value but always appear grey

atwellpub commented 9 years ago

Looking into it.

atwellpub commented 9 years ago

Ok after playing with it the color picker values are saving for me, but the empty (non populated) colors were causing an infinite json array to build and build on itself causing a memory creep.

I don't think this is an inbound issue, I think it's an ACF one. not positive though. The solution seemed to be setting the default color in the config.php.

I'm going to pull these latest updates and test some more.

DavidWells commented 9 years ago

Update ACF PRO to latest from here: davidwells.io/wp-content/uploads/dl/advanced-custom-fields-pro.zip

DavidWells commented 9 years ago

After the ACF is upgraded, check out the color picker on normal posts/pages as well to make sure it's not happening everywhere

atwellpub commented 9 years ago

Running the latest ACF Pro so I don't think it's that. I managed ti get it stable with special handling from the color picker. I can't account for why ACF was not working well with color picker. It would start out as a string and then store the color picker in an array, as a json object, but store it in key 1 instead of 0 while 0 was empty. I don't think it has anything to do with the way we handle saving ACF data.

It seems to be working stably now.

DavidWells commented 9 years ago

Dequeue the other colorpicker jquery from loading from old CTA metabox setup. They might be conflicting

atwellpub commented 9 years ago

https://github.com/inboundnow/inbound-mailer/issues/49