search

inboundnow / inbound-mailer-retired

0 stars 1 forks source link

Repeater fields not saved #60

Closed daprela closed 8 years ago

daprela commented 8 years ago

Repeater fields are not saved. If you try to create a new email with repeater fields for example from the sidebar template, you can actually add the fields and save them but if you reload the edit page you'll see that they are not there anymore, meaning that they haven't been saved.

I don't know when this bug has appeared, at the and of August it worked, then I started working on landing pages and haven't touched the mailer anymore.

DavidWells commented 8 years ago

@atwellpub dont landing pages and mailer use the same templating engine?

If not we need to sync them up, to simplify our code base

atwellpub commented 8 years ago

They are not the same but they are similar. They can be consolidated but I want to wait to consolidate them, at the moment I want them as separate classes, then when all is stable I'll merge them into shared class.

atwellpub commented 8 years ago

@daprela

I've checked it out and I can get the 'Email Body' repeaters to work but I can not get the 'Sidebar' social links to save. Looking into it.

http://screencast.com/t/gIiBtQV6d3S

atwellpub commented 8 years ago

Latest commit should show better performance. Might make past created templates not work.

daprela commented 8 years ago

It works but now I get colors in a two elements array, with the color code saved in element 1.

It looks like after your modifications colors are saved as arrays instead of simple strings.