search

inboundnow / inbound-mailer-retired

0 stars 1 forks source link

[email-template] Photographer #61

Closed daprela closed 8 years ago

daprela commented 8 years ago

I'm adding this new email template. This template is pretty sophisticated, and can be even more powerful by adding more color options. My suggestion would be to 'reduce' this template to more basic options like eliminating the feature box on top, the image background on the header, the advertising banner in the sidebar, and put those options in a premium version of the template

daprela commented 8 years ago

The template needs some refinements. Please give it a look

atwellpub commented 8 years ago

I think it's bad ass. My favorite so far.

atwellpub commented 8 years ago

@daprela

I'm running some tests with click tracking and noticed that the test email loses a background color: http://screencast.com/t/O9Cg5CbIL

daprela commented 8 years ago

What email client are you using?

atwellpub commented 8 years ago

thunderbird

atwellpub commented 8 years ago

Also I'm trying to figure this one out: https://github.com/inboundnow/inbound-mailer/blob/develop/templates/photographer/index.php#L91

If $header_bg_image is empty the the url() inline styling is causing the WordPress instance to load twice. I'm not sure why. I wouldn't spend any time on this unless you intuitively know why it would do that. It's causing issues with email link tracking. I'll spend time looking into this tomorrow. Mark it down here for now.

daprela commented 8 years ago

I have no idea but to fix the issue I could simply load a default image in the header in case it is empty, what do you think?

daprela commented 8 years ago

Re: the background issue, it could be that Thunderbird doesn't like the background-color style attribute. Can you please try adding this background="<?php echo $cta_bg_color; ?>" at the end of this line as a single attribute, outside the style attribute and test the email again https://github.com/inboundnow/inbound-mailer/blob/develop/templates/photographer/index.php#L139

daprela commented 8 years ago

By the way, the issue with the $header_bg_image empty doesn't happen in my installation, tested in chrome and Firefox. I was thinking at this point to use a ternary operator to add or not the whole attribute background-image and also background-size. This should eliminate the problem

atwellpub commented 8 years ago

Looks like our link rebuilder was replacing all instances of # with craziness. Colors are working now.

atwellpub commented 8 years ago

Found out the reason of the double load:

background as an html attribute causes a double load. We'll have to avoid it in the future: https://bugs.php.net/bug.php?id=10599

Strange strange!

daprela commented 8 years ago

Where necessary the ternary operator is a good solution in my opinion. The attribute is added only when there is an image url, so no risk of double loading

atwellpub commented 8 years ago

to make sure we are sync'd:

Nein (throws page load twice) `

` _Ja_ `
` _Ja_ `
` _Ja_ `
`
daprela commented 8 years ago

I'll have to check all other mail templates sometimes in the future to make sure that these problems don't affect them too, now that we know them

atwellpub commented 8 years ago

I ran a search the other day they seem to be clean!

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.