search

inboundnow / inbound-pro

Inbound Pro Plugin for WordPress - Landing Page Framework, Calls to Action Framework, Visitor Analytics & List Segmentation, Email Campaigns & Marketing Automation
https://www.inboundnow.com
31 stars 17 forks source link

Fatal errors when plugins are disabled. #130

Closed DavidWells closed 8 years ago

DavidWells commented 8 years ago

This is an error when pro is activated and leads gets toggled off from settings.

We need to make sure that any code that relies on one of these core classes are wrapped in conditionals to make sure we don't fatal error peoples sites

image

Fatal error: Class 'Inbound_Leads' not found in /Users/davidwells/Dropbox/Sites/WP.dev/wp-content/plugins/_inbound-pro/core/inbound-automation/definitions/action.send_email.php on line 23

DavidWells commented 8 years ago

Another Leads class call from within pro. When leads disabled fatals appears

Fatal error: Class 'Leads_Field_Map' not found in /Users/davidwells/Dropbox/Sites/WP.dev/wp-content/plugins/_inbound-pro/classes/admin/class.lead-field-mapping.php on line 29

atwellpub commented 8 years ago

are you 1. 0.6 in pro? *looking over the issue one other question is in your settings area do you have the leads plugin disabled (turned off)?

DavidWells commented 8 years ago

Yes I disabled leads from inbound-pro settings. This is what caused the fatal

On Sun, Dec 13, 2015 at 9:01 PM, Hudson Atwell notifications@github.com wrote:

are you 1. 0.6 in pro? *looking over the issue one other question is in your settings area do you have the leads plugin disabled (turned off)?

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/inbound-pro/issues/130#issuecomment-164343143 .

atwellpub commented 8 years ago

I am having a hard time repeating the error. Are you on the master branch or dev branch?

atwellpub commented 8 years ago

I notice you're committing to the master branch so I'm thinking the issues are with you working with the master branch and not the dev. The master is way behind. I'm about to update it though.

atwellpub commented 8 years ago

These are both pulled from shared and should not disappear if leads is disabled.

atwellpub commented 8 years ago

Ok I updated master and it does not seem to be an issue on either branch. The changes to Inbound Automation were reverted too so there is no conditional. Changes to Inbound Automation have to be made to the stand alone repository to stay in.