search

inboundnow / retired-cta

Create Calls to Action for your WordPress site. Monitor and improve conversion rates, run A/B split tests, customize your own CTA templates and more
http://www.inboundnow.com/cta/
1 stars 3 forks source link

Remove API call from font-awesome plugin #131

Closed DavidWells closed 9 years ago

DavidWells commented 9 years ago

https://github.com/inboundnow/cta/blob/master/shared/assets/plugins/advanced-custom-fields-font-awesome/better-font-awesome-library/better-font-awesome-library.php#L457

This api call means we have to rely on http://api.jsdelivr.com/v1/jsdelivr/libraries/fontawesome/?fields=versions,lastversion always been up and available. This is bad.

Perhaps we should pull out the data and save in plugin?

Caused this error locally for me: http://www.screencast.com/t/kGB4Kl0etjkH