search

inboundnow / retired-cta

Create Calls to Action for your WordPress site. Monitor and improve conversion rates, run A/B split tests, customize your own CTA templates and more
http://www.inboundnow.com/cta/
1 stars 3 forks source link

Rare infinite redirect loop #162

Open atwellpub opened 8 years ago

atwellpub commented 8 years ago

@DavidWells

Can you think of any reason this line would cause an infinite redirect loop after a couple of page refreashes on select servers? And is it ok to remove? I'm thinking it is. Going to test.

https://github.com/inboundnow/cta/blob/master/shared/assets/js/frontend/analytics/inboundAnalytics.js#L1112

DavidWells commented 8 years ago

Doesn't look like it should.

Try replacing the Ajax polyfill with a different Ajax setup from npm

Smallxhr is a library that is tiny and will do Ajax requests. Not sure if it supports older IE

On Apr 15, 2016, at 7:25 PM, Hudson Atwell notifications@github.com wrote:

@DavidWells

Can you think of any reason this line would cause an infinite redirect loop after a couple of page refreashes on select servers? And is it ok to remove? I'm thinking it is. Going to test.

https://github.com/inboundnow/cta/blob/master/shared/assets/js/frontend/analytics/inboundAnalytics.js#L1112

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

atwellpub commented 8 years ago

Looks like it's really an issue with PHP's setcookie() function causing the loop. Seen it with two clients, still fishing for a solution.