search

inboundnow / retired-cta

Create Calls to Action for your WordPress site. Monitor and improve conversion rates, run A/B split tests, customize your own CTA templates and more
http://www.inboundnow.com/cta/
1 stars 3 forks source link

Not including custom JS assets files from template #65

Closed gmauricio closed 9 years ago

gmauricio commented 10 years ago

Hey,

I noticed that sometimes the js files insided assets dir of my template are not included, then browsing the code, I found this at classes/class.cta.render.php , lines 265, 266:

$has_js_dir = WP_CTA_PATH.'templates/'.$template['slug'].'/assets/css/'; $has_style_dir = WP_CTA_PATH.'templates/'.$template['slug'].'/assets/js/';

$has_js_dir checks for css, and $has_style_dir checks for js.

gmauricio commented 10 years ago

Also, check line 280,

if(file_exists($has_js_dir))

should be changed to $has_style_dir

atwellpub commented 10 years ago

@gmauricio would you mind forking cta, making the changes, and offering a pull request? If there is no time I understand and will look into it asap.

gmauricio commented 10 years ago

I'll try to make some time for it this weekend

atwellpub commented 10 years ago

Awesome. I see and accepted. Thank you @gmauricio