inboundnow / retired-landing-pages

Create landing pages for your WordPress site. Monitor and improve conversion rates, run A/B split tests, customize your own templates and more.
http://www.inboundnow.com/landing-pages/
GNU General Public License v2.0
4 stars 2 forks source link

Advanced Custom Fields Support #174

Closed atwellpub closed 8 years ago

atwellpub commented 9 years ago

Advanced custom fields support for pro users is now in place. We are adding in ACF Lite support for free users. Right now the updates are in the 'Refactoring_metabox_modules' branch.

Here's where we are keeping our demo ACF template at the moment: https://bitbucket.org/inboundnow/acf-landing-page-example

atwellpub commented 9 years ago

@DavidWells @daprela

Hey guys, would you create a landing page with countdown lander with 3 variations?

I'm about to push the Countdown ACF version and want to see how it fits with the legacy version data and if there are any issues.

DavidWells commented 9 years ago

ok I have it created

atwellpub commented 9 years ago

I think we are going to have to include acf in landing pages/shared.

DavidWells commented 9 years ago

yes acf normal would go in /shared/. http://plugins.svn.wordpress.org/advanced-custom-fields/trunk/ minus assets not needed like screenshots

When inbound-pro gets ran through it's production build, /shared/acf normal will be removed/replaced with acf pro files

One concern I have is conflicts with different versions of ACF normal/pro out there... Not sure if this will happen or not

On Tue, Aug 18, 2015 at 2:46 PM, Hudson Atwell notifications@github.com wrote:

I think we are going to have to include acf in landing pages/shared.

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/landing-pages/issues/174#issuecomment-132365396 .

atwellpub commented 9 years ago

ok pushed.

atwellpub commented 9 years ago

More handling for acf + countdown. Still running tests. Will pick up … …tomorrow.

https://github.com/inboundnow/landing-pages/commit/0b8ddb6db8f374c081d15d6572fedd39971394d3

atwellpub commented 9 years ago

@DavidWells @daprela

Notice, when defining field groups in config.php files for our free version we have to use:

register_field_group

instead of:

acf_add_local_field_group

https://github.com/elliotcondon/acf/issues/412

atwellpub commented 9 years ago

@DavidWells

It also looks like the 'Marketing' & 'Add Media' buttons dissapear when a user is not using ACF Pro.