search

inboundnow / retired-landing-pages

Create landing pages for your WordPress site. Monitor and improve conversion rates, run A/B split tests, customize your own templates and more.
http://www.inboundnow.com/landing-pages/
GNU General Public License v2.0
4 stars 2 forks source link

No bullet pointes on legacy half and half [support request] #258

Open atwellpub opened 9 years ago

atwellpub commented 9 years ago

Hey David,

We are about ready for a push, but I've not given the go yet mostly because of this issue right here I could use some help on: https://github.com/inboundnow/landing-pages/issues/221

And in the meantime, know how to help this guy?: http://support.inboundnow.com/support/topic/no-bullets-ok-sign-in-list-item/

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

DavidWells commented 9 years ago

Specific to that guys site: http://www.screencast.com/t/soKfqdHA3Ev

He is missing pseudo selectors

atwellpub commented 9 years ago

Not sure how to address the support ticket atm. Will you take care of it?

DavidWells commented 9 years ago

Do you know how to inline these styles differently? https://github.com/inboundnow/landing-pages/issues/221#issuecomment-144246752

DavidWells commented 9 years ago

Bullets are still broken http://www.screencast.com/t/CH6L0Z1O3e5

@atwellpub do you know another way to include these dynamic styles?

atwellpub commented 9 years ago

Where are the styles coming from? The bullet points are restored if Inbound Pro is active, but I don't get why it would do it. But no matter what they are not checks.

This one baffles me.

DavidWells commented 9 years ago

They are coming from here: https://github.com/inboundnow/landing-pages/blob/master/shared/shortcodes/inbound-shortcodes.php#L531-L562

ACF normal strips out my inlined style tag from content and that breaks the button styles

On Thu, Oct 15, 2015 at 4:04 PM, Hudson Atwell notifications@github.com wrote:

Where are the styles coming from? The bullet points are restored if Inbound Pro is active, but I don't get why it would do it. But no matter what they are checks.

I really have no clue what is going on.

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/landing-pages/issues/258#issuecomment-148547486 .

atwellpub commented 9 years ago

ACF is removing inline styling? What's the inline style tag?

DavidWells commented 9 years ago

This code: https://github.com/inboundnow/landing-pages/blob/master/shared/shortcodes/inbound-shortcodes.php#L532-L561

On Thu, Oct 15, 2015 at 5:37 PM, Hudson Atwell notifications@github.com wrote:

ACF is removing inline styling? What's the inline style tag?

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/landing-pages/issues/258#issuecomment-148561496 .

atwellpub commented 9 years ago

I think we could, when the shortcode is fired, hook an output function into the template footer: https://github.com/inboundnow/landing-pages/blob/master/templates/svtle/index.php#L234-L235