[acf] Jasmine - Githubissues

inboundnow / retired-landing-pages

Create landing pages for your WordPress site. Monitor and improve conversion rates, run A/B split tests, customize your own templates and more.

http://www.inboundnow.com/landing-pages/

GNU General Public License v2.0

4 stars 2 forks source link

[acf] Jasmine #302

Closed daprela closed 8 years ago

daprela commented 8 years ago

New template based on theme 17

daprela commented 8 years ago

The template is finished. Needs just some more testing for edge cases.

Please test it and let me know

daprela commented 8 years ago

Template finished. Now I'm going to start the next one

atwellpub commented 8 years ago

In testing I've found:

Featured section -> background image is a text field instead of a image upload field.
featured image has no margin/padding at bottom (meant to be this way?)
creators avatar overlaps content

http://screencast.com/t/0azptBbd2g7

What a powerful and complex template. Are you getting jaded on template development yet?

jasmine

daprela commented 8 years ago

I missed the featured section background image issue but everything else should be fixed. I tried to upload a new fixed version of the template yesterday, and don't understand why it didn't fix all the issues. I made a css adjustment that I have in my local install, and it's also in the Bitbucket repo but when I upload the new version of the template it disappears. It's driving me crazy

daprela commented 8 years ago

And yes, the featured image is meant to sit on the bottom without any padding or margin

daprela commented 8 years ago

Wait, when have you downloaded the template? I see bugs in the template that I've fixed a couple of days ago. The only bug that I missed is the image in the creators section, which is strange anyway because it's set to be a circle. Still trying to figure out the problem in the demo website. I think that I will uninstall the template and re-upload it

atwellpub commented 8 years ago

Hey Giulio I believe you. After I had tested the page I opened sourcetree and discovered I had not completed the pull confirmation dialog. Sorry about that I'll do better on making sure I'm 100% updated before testing.