Failed geolocation connection causes fatal error. - Githubissues

inboundnow / retired-leads

Track visitor activity, capture and manage incoming leads, and send collected emails to your email service provider for WordPress

http://www.inboundnow.com/leads/

11 stars 3 forks source link

Failed geolocation connection causes fatal error. #120

Closed atwellpub closed 9 years ago

atwellpub commented 9 years ago

Geolocation connect was causing a fatal error. Will need to investigate this further to make sure it's still working and not an isolated incident with the client.

Leads were still making it in, but the inbound_store_lead_post function was not running causing some third party integrations not to fire.

[x] Fix issue with fatal
[x] Test geoplugin connect to see if it still works ( service is down )
[x] Temporarily remove geolocation services
[ ] Maybe offload this connect to when the lead profile is loaded for the first time rather than during lead storage to shave time.

Ideally a replacement would be a service provided by Google API or another major provider.

atwellpub commented 9 years ago

Possible replacements: http://stackoverflow.com/questions/409999/getting-the-location-from-an-ip-address

DavidWells commented 9 years ago

Can we turn this back on but get the actual address when the person views the lead and not on lead save?

atwellpub commented 9 years ago

I'm not sure if the Geoip.net service is back up or now. But if it is, we can. I need to test somewhere besides localhost to find out.

atwellpub commented 9 years ago

ok have it back in. Looks like the service is working once again.

DavidWells commented 9 years ago

where does the check happen?

On Thu, Aug 27, 2015 at 5:23 PM, Hudson Atwell notifications@github.com wrote:

ok have it back in.

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/leads/issues/120#issuecomment-135590532.

atwellpub commented 9 years ago

Where the look up is happening https://github.com/inboundnow/leads/blob/master/classes/class.metaboxes.wp-lead.php#L77 https://github.com/inboundnow/leads/blob/master/classes/class.metaboxes.wp-lead.php#L240-L322

Where the IP is stored: https://github.com/inboundnow/leads/blob/master/shared/classes/class.lead-storage.php#L164-L168

It's due for a refactor, but this is how it's handled at the moment.