Submit changed to click?

inboundnow / retired-leads

Track visitor activity, capture and manage incoming leads, and send collected emails to your email service provider for WordPress

http://www.inboundnow.com/leads/

11 stars 3 forks source link

Submit changed to click? #13

Closed DavidWells closed 11 years ago

DavidWells commented 11 years ago

Hey Hudson,

Saw in a commit you changed 'submit' to a click event on https://github.com/inboundnow/leads/blob/master/shared/tracking/js/store.lead.ajax.js#L4

Was this on purpose? Forms are firing immediately on an input click.

DavidWells commented 11 years ago

It looks like this was for link tracking. I think they will need to be separate listener though https://github.com/inboundnow/leads/blob/master/shared/tracking/js/store.lead.ajax.js#L10

DavidWells commented 11 years ago

video http://www.screencast.com/t/wt8SbfQY

atwellpub commented 11 years ago

Separated tracking support for links and forms. forms now are dependant on submit and is being tracked by class wpl-track-me and links are dependant on click and are tracked by class wpl-track-me-link