inboundnow / retired-leads

Track visitor activity, capture and manage incoming leads, and send collected emails to your email service provider for WordPress
http://www.inboundnow.com/leads/
11 stars 3 forks source link

Inbound Forms - Question #133

Open atwellpub opened 9 years ago

atwellpub commented 9 years ago

User is having trouble with this file not being available in his cloud hosted environment. Is there an alternative to loading this file directly?

https://github.com/inboundnow/leads/blob/master/shared/shortcodes/shortcodes-fields.php#L9-L11

See support request: http://support.inboundnow.com/support/topic/fatal-error-on-subfolder-install-of-wp/page/2/

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26001193-inbound-forms-question?utm_campaign=plugin&utm_content=tracker%2F260752&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F260752&utm_medium=issues&utm_source=github).
DavidWells commented 9 years ago

Shortcodes is one of those tricky bits of the software.

In reality we need to start systematically removing all of them minus the ones that drive forms and port them to their own add-on that we will eventually retire.

The shortcode setup was forked from another theme long ago.

I don't think it needs to be included this way but I'm not sure how to fix it. I will have a look

Do you have any ideas?

On Thu, Aug 20, 2015 at 12:14 PM, Hudson Atwell notifications@github.com wrote:

Assigned #133 https://github.com/inboundnow/leads/issues/133 to @DavidWells https://github.com/DavidWells.

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/leads/issues/133#event-388042930.

atwellpub commented 9 years ago

Why exactly does it need to load it's own wp-load.php? Maybe we can find a way to hook all that into an init and then load an wp-admin url that opens the shortcode page rather than the shortcode page directly?

DavidWells commented 9 years ago

Honestly not sure. Remove it and see what explodes =P

I can't see any wordpress core specific stuff in that file below

On Thu, Aug 20, 2015 at 1:02 PM, Hudson Atwell notifications@github.com wrote:

Why exactly does it need to load it's own wp-load.php? Maybe we can find a way to hook all that into an init and then load an wp-admin url that opens the shortcode page rather than the shortcode page directly?

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/leads/issues/133#issuecomment-133155568.

DavidWells commented 9 years ago

I think it had to to will all the shortcodes in /shared/shortcodes/shortcodes folder. I think some of them use wordpress functions but they are global variables and not in the wordpress context

On Thu, Aug 20, 2015 at 1:04 PM, David Wells david@inboundnow.com wrote:

Honestly not sure. Remove it and see what explodes =P

I can't see any wordpress core specific stuff in that file below

On Thu, Aug 20, 2015 at 1:02 PM, Hudson Atwell notifications@github.com wrote:

Why exactly does it need to load it's own wp-load.php? Maybe we can find a way to hook all that into an init and then load an wp-admin url that opens the shortcode page rather than the shortcode page directly?

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/leads/issues/133#issuecomment-133155568.

atwellpub commented 9 years ago

Everything but here seems ok: http://screencast.com/t/qpbDKtYpVZ7

I'll take a crack at it.

DavidWells commented 9 years ago

Form shortcode and https://github.com/inboundnow/leads/blob/master/shared/shortcodes/shortcodes-fields.php#L15 need to roll out of there but the setup is super flimsy right now

I'm afraid if we move, the form builder will break.

On Thu, Aug 20, 2015 at 1:08 PM, Hudson Atwell notifications@github.com wrote:

Everything but here: http://screencast.com/t/qpbDKtYpVZ7

I'll take a crack at it.

— Reply to this email directly or view it on GitHub https://github.com/inboundnow/leads/issues/133#issuecomment-133157015.