inboundnow / retired-leads

Track visitor activity, capture and manage incoming leads, and send collected emails to your email service provider for WordPress
http://www.inboundnow.com/leads/
11 stars 3 forks source link

Issues with GEO IP #163

Open DavidWells opened 8 years ago

DavidWells commented 8 years ago

I have a ton of leads on my personal site.

What exactly is the "Leads plugin requires a database upgrade : Run Upgrade Processes" doing?

Dont wanna run and wait if I dont have to

Perhaps updating the message to users about why they need to update would be helpful

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30245055-issues-with-geo-ip?utm_campaign=plugin&utm_content=tracker%2F260752&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F260752&utm_medium=issues&utm_source=github).
atwellpub commented 8 years ago

The lead update stops sourcing event data recorded in the activity tav out of meta pairs and stores event data into a inbound_events table. This opens up our event logging (form submissions & cta clicks & email clicks & unsubscribe events & custom events) to better/faster/more complex queries.

The data migration is necessary because Leads 'Activity' tab is looking to the inbound_events table for the data now instead of calculating the data via meta pair storage.

An FYI though, lead page views and conversion paths are still stored as meta data.

DavidWells commented 8 years ago

Batch update is breaking geo data

Before batch update: image

After:

image

atwellpub commented 8 years ago

The batch processing does not alter the geoobject nor the normal upgrade routines: https://github.com/inboundnow/leads/blob/master/classes/class.batch-processing.php#L90-L200 https://github.com/inboundnow/leads/blob/master/classes/class.activation.upgrade-routines.php

It has to be a deeper issue: https://github.com/inboundnow/leads/blob/master/classes/class.metaboxes.wp-lead.php#L700-L789 https://github.com/inboundnow/leads/search?utf8=%E2%9C%93&q=wpleads_ip_address

Not sure what at the moment.

Maybe an auto update on the geo data and the 3rd party service was down.