search

inboundnow / retired-leads

Track visitor activity, capture and manage incoming leads, and send collected emails to your email service provider for WordPress
http://www.inboundnow.com/leads/
11 stars 3 forks source link

Wrong css code in customizer-editor.post.css #170

Open daprela opened 8 years ago

daprela commented 8 years ago

The file customizer-editor.post.css contains nested selectors. This is a common practice in SASS and LESS but not admitted in the final version that the browser reads.

The whole file need to be reviewed and fixed

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/31994470-wrong-css-code-in-customizer-editor-post-css?utm_campaign=plugin&utm_content=tracker%2F260752&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F260752&utm_medium=issues&utm_source=github).
DavidWells commented 8 years ago

Look at the gulp file. It will build the CSS the browser needs

I believe the terminal command is gulp css-watch

It's using postCSS to build.

The nested selectors are ensuring that the styles won't be broken by other themes or plugins

On Mar 17, 2016, at 9:40 AM, Giulio notifications@github.com wrote:

The file customizer-editor.post.css contains nested selectors. This is a common practice in SASS and LESS but not admitted in the final version that the browser reads.

The whole file need to be reviewed and fixed

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

daprela commented 8 years ago

Thanks for the info. Besides that, I'll probably need to move this issue in cta because the file is in the shared folder

atwellpub commented 8 years ago

@DavidWells

David are you saying that the customizer-editor.post.css is develeped inside nests and the gulp is used to parse the nesting and created customizer-editor.css?

DavidWells commented 8 years ago

Yes. The gulp task writes the browser readable CSS

On Mar 17, 2016, at 4:26 PM, Hudson Atwell notifications@github.com wrote:

@DavidWells

David are you saying that the customizer-editor.post.css is develeped inside nests and the gulp is used to parse the nesting and created customizer-editor.css?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub