incedo / fabricate

Automatically exported from code.google.com/p/fabricate
0 stars 0 forks source link

exception at after() with some arguments #30

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Under parallel_ok, and after() is called with some arguments, FAB.py script 
fails with exception. see attached files.
- FAB.py
- auto.sh (to run ./FAB.py in some conditions)
- log-1.24.txt (output of auto.sh)

What is the expected output? What do you see instead?
In parallel mode, run() registers groupname(and some information) in _group, 
and after() function waits the jobs listed in _groups. However, if a 
commandline is skipped due to cmdline_outofdate() or so, the group name is not 
registered to _groups, which causes key error exception. 

What version of the product are you using? On what operating system?
fabricate 1.24
Python 2.6.6
Linux (SL 5.8)

Please provide any additional information below.
I would like to suggest some modification to add groupname even if the 
commandline is skipped (_Groups.add_fake() method to register groupname 
anyway). I am not sure about this problem, so I am pleased with more better 
solutions.

Original issue reported on code.google.com by Aoki.Takaaki on 21 Jun 2012 at 11:31

Attachments:

GoogleCodeExporter commented 9 years ago
Good catch.

Suggest a slightly re-worded fix attached

Original comment by ele...@gmail.com on 22 Jun 2012 at 3:00

Attachments:

GoogleCodeExporter commented 9 years ago
As of r151 I have this problem as well.  I have combine the above naming change 
with the doc comments from the original post.  FAB.py and auto.sh are a great 
tool to debug these parallel build issues.

Original comment by jli...@gmail.com on 28 Feb 2013 at 8:13

Attachments:

GoogleCodeExporter commented 9 years ago
Patch applied. Will be pushed in the next update.

Original comment by simon.al...@gmail.com on 3 May 2013 at 11:10

GoogleCodeExporter commented 9 years ago
Fixed in version 1.26 (soon to be pushed)

Original comment by simon.al...@gmail.com on 22 Jul 2013 at 9:41