inception-project / inception

INCEpTION provides a semantic annotation platform offering intelligent annotation assistance and knowledge management.
https://inception-project.github.io
Apache License 2.0
602 stars 153 forks source link

Problems with liquibase preconditions in recommendation module #161

Closed betoboullosa closed 6 years ago

betoboullosa commented 6 years ago
reckart commented 6 years ago

Also, most of the Liquibase configuration for these tables are still in inception-active-learning/src/main/resources/de/tudarmstadt/ukp/inception/active-learning/model/db-changelog.xml but the entities are now in inception-recommendation-api/src/main/java/de/tudarmstadt/ukp/inception/recommendation/api/model. I guess the db-changelog.xml needs to be merged with the one in inception-recommendation-api?

betoboullosa commented 6 years ago

Changelog from Actdive Learning has been deleted, its contents were merged into the recommedation module changeset.

betoboullosa commented 6 years ago

@rcffc I've noticed that the demo server recommender table doesn't have the classifierId column anymore. However, when creating the INCEpTION database from scratch using liquibase, that column is still being created and is not deleted in the end. Is that column still used? Otherwise, where is the delete column changeset for it?

rcffc commented 6 years ago

It is not used anymore. I have pushed a commit which drops the column.