search

inception-project / inception

INCEpTION provides a semantic annotation platform offering intelligent annotation assistance and knowledge management.
https://inception-project.github.io
Apache License 2.0
589 stars 148 forks source link

Unable to mark document as curation-finished if a required document-level annotation feature is missing #4866

Open reckart opened 3 months ago

reckart commented 3 months ago

Describe the bug If a document has been opened in sidebar-curation mode and a document-level annotation with a required feature has been added (e.g. manually or via a singleton), then the document cannot be marked as curation-finished on the curation page (also not on the annotation page in curation mode probable). However, on the curation page, this is quite annoying because there is no way to access document-level annotations on the curation page.

To Reproduce Steps to reproduce the behavior:

  1. Create document-level annotation layer with required feature
  2. Create annotation of that layer while in sidebar-curation mode on the annotation page but do not fill in required feature
  3. Open the document on the curation page and try marking it as finished
  4. See error

Expected behavior Probably the best would be if document-level annotations could be properly curated.

Please complete the following information:

PotOfJam commented 3 months ago

Can you explain the 2. of your reproduction methodology ? i'm not sure of what you are talking about when you say "sidebar-curation mode".

Also i'm pretty sure you made a mistake in the version of the next milestone, it should be 33.1 not 34.1.

Can we agree that at the time there is no way to curate document-level annotation ?

reckart commented 3 months ago

Sidebar curation mode is an experimental mode that allows curating documents on the annotation page. It works ok but there are a few quirks.

In that mode, it is also possible to switch to the document-level annotation sidebar and make annotations there. True curation is not possible because you will only see the document-level annotations of the curator, not those of the annotators.

I do not think a fix for this will make it into the 33.x series since adding document-level curation will be a larger task. If a fix makes it into 33.x, then it would be some kind of workaround that ignores document-level features during validation when closing a document on the curation page.

PotOfJam commented 3 months ago

Okay thanks for the answer