incf-nidash / PyNIDM

Other
21 stars 31 forks source link

Replace uses of `urllib.request` with `requests` #359

Closed jwodder closed 1 year ago

jwodder commented 1 year ago

Part of #325.

codecov-commenter commented 1 year ago

Codecov Report

Merging #359 (c3fe16c) into master (a4c1ba2) will increase coverage by 0.05%. The diff coverage is 55.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   33.63%   33.68%   +0.05%     
==========================================
  Files          50       51       +1     
  Lines        7050     7062      +12     
  Branches     1781     1784       +3     
==========================================
+ Hits         2371     2379       +8     
- Misses       4500     4504       +4     
  Partials      179      179              
Impacted Files Coverage Δ
src/nidm/experiment/Utils.py 27.26% <0.00%> (-0.10%) :arrow_down:
src/nidm/experiment/tools/nidm2bids.py 0.00% <0.00%> (ø)
src/nidm/experiment/CDE.py 75.00% <100.00%> (ø)
src/nidm/experiment/Query.py 71.89% <100.00%> (ø)
src/nidm/util.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

yarikoptic commented 1 year ago

requests are already used, so I guess it does make sense to harmonize all http interactions through it. FWIW here is usage points:

src/nidm/experiment/Query.py:import requests
src/nidm/experiment/Query.py:            r2 = requests.post(
src/nidm/experiment/Query.py:            requests.post(
src/nidm/experiment/Utils.py:import requests
src/nidm/experiment/Utils.py:    response = requests.post(

Just need a conflict resolved first

jwodder commented 1 year ago

@yarikoptic Conflict resolved.

github-actions[bot] commented 1 year ago

:rocket: PR was released in v4.0.0 :rocket: