incf-nidash / PyNIDM

Other
21 stars 31 forks source link

Pare down giant comment blocks that largely do what Git already does #363

Closed jwodder closed 1 year ago

jwodder commented 1 year ago

Part of #325.

@yarikoptic Question: Should the persons listed in the "Coded by" fields removed by this PR be listed in a CONTRIBUTORS file or similar? There are only two such persons listed, David Keator and Ashmita Kumar, both of whom are already listed as authors in the Git history and as contributors on GitHub.

codecov-commenter commented 1 year ago

Codecov Report

Merging #363 (5c099f6) into master (ab539e5) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   33.59%   33.59%           
=======================================
  Files          51       51           
  Lines        7052     7052           
  Branches     1784     1784           
=======================================
  Hits         2369     2369           
  Misses       4504     4504           
  Partials      179      179           
Impacted Files Coverage Δ
src/nidm/experiment/Query.py 71.73% <ø> (ø)
src/nidm/experiment/tools/bidsmri2nidm.py 0.00% <ø> (ø)
src/nidm/experiment/tools/csv2nidm.py 0.00% <ø> (ø)
src/nidm/experiment/tools/nidm2bids.py 0.00% <ø> (ø)
src/nidm/experiment/tools/nidm_concat.py 0.00% <ø> (ø)
src/nidm/experiment/tools/nidm_convert.py 0.00% <ø> (ø)
src/nidm/experiment/tools/nidm_linreg.py 56.64% <ø> (ø)
src/nidm/experiment/tools/nidm_merge.py 0.00% <ø> (ø)
src/nidm/experiment/tools/nidm_query.py 23.68% <ø> (ø)
src/nidm/experiment/tools/nidm_utils.py 0.00% <ø> (ø)
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dbkeator commented 1 year ago

Yes, ok with me.

yarikoptic commented 1 year ago

per @dbkeator blessing (Thank you!), let's proceed!

github-actions[bot] commented 1 year ago

:rocket: PR was released in v4.0.0 :rocket: