Open all text files with UTF-8 encoding

jwodder commented 1 year ago

Calling open() without an explicit encoding uses the OS encoding, which is not always sensible. See PEP 597 et alii.

codecov-commenter commented 1 year ago

Codecov Report

Merging #373 (18abbc2) into master (1472357) will increase coverage by 0.04%. The diff coverage is 13.63%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   33.59%   33.64%   +0.04%     
==========================================
  Files          51       51              
  Lines        7030     7030              
  Branches     1784     1784              
==========================================
+ Hits         2362     2365       +3     
+ Misses       4488     4485       -3     
  Partials      180      180

Impacted Files	Coverage Δ
src/nidm/experiment/Query.py	`72.00% <0.00%> (ø)`
src/nidm/experiment/Utils.py	`27.29% <0.00%> (ø)`
src/nidm/experiment/tools/bidsmri2nidm.py	`0.00% <0.00%> (ø)`
src/nidm/experiment/tools/csv2nidm.py	`0.00% <ø> (ø)`
src/nidm/experiment/tools/nidm2bids.py	`0.00% <0.00%> (ø)`
...nidm/experiment/tools/nidm_affinity_propagation.py	`0.00% <0.00%> (ø)`
.../experiment/tools/nidm_agglomerative_clustering.py	`0.00% <0.00%> (ø)`
src/nidm/experiment/tools/nidm_convert.py	`0.00% <0.00%> (ø)`
src/nidm/experiment/tools/nidm_gmm.py	`0.00% <0.00%> (ø)`
src/nidm/experiment/tools/nidm_kmeans.py	`0.00% <0.00%> (ø)`
... and 4 more

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

yarikoptic commented 1 year ago

well, some of those files should not even be utf8 but AFAIK should be ascii... but I guess it would generally be more robust etc to just generally assume UTF-8 these days.

github-actions[bot] commented 1 year ago

:rocket: PR was released in v4.0.0 :rocket:

incf-nidash / PyNIDM

Open all text files with UTF-8 encoding #373

Codecov Report